Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response formatting for channel upgrades msg server handlers #3825

Closed
3 tasks
damiannolan opened this issue Jun 12, 2023 · 2 comments
Closed
3 tasks

Response formatting for channel upgrades msg server handlers #3825

damiannolan opened this issue Jun 12, 2023 · 2 comments
Labels
04-channel type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@damiannolan
Copy link
Contributor

damiannolan commented Jun 12, 2023

Summary

Discuss alternatives for formatting response information in channel upgrades msg server handlers.

See thread and thread.

We currently chose to opt for returning (Channel, Upgrade) from WriteUpgradeTryChannel in order to have the response values up to date. However, ideally we would keep WriteX funcs void, with zero return args.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton
Copy link
Contributor

chatton commented Nov 22, 2023

Discussing with @damiannolan , we can keep the WriteUpgradeTryChannel fn the same, but update WriteUpgradeInitChannel to use the same method signature (return Channel, Upgrade) to stay consistent.

@crodriguezvega
Copy link
Contributor

The signature of WriteUpgradeInitChannel changed already in #5264, therefore the issue can be closed.

@github-project-automation github-project-automation bot moved this from Todo to Done in ibc-go Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

No branches or pull requests

4 participants