You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently chose to opt for returning (Channel, Upgrade) from WriteUpgradeTryChannel in order to have the response values up to date. However, ideally we would keep WriteX funcs void, with zero return args.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Discussing with @damiannolan , we can keep the WriteUpgradeTryChannel fn the same, but update WriteUpgradeInitChannel to use the same method signature (return Channel, Upgrade) to stay consistent.
Summary
Discuss alternatives for formatting response information in channel upgrades msg server handlers.
See thread and thread.
We currently chose to opt for returning
(Channel, Upgrade)
fromWriteUpgradeTryChannel
in order to have the response values up to date. However, ideally we would keepWriteX
funcs void, with zero return args.For Admin Use
The text was updated successfully, but these errors were encountered: