Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify/refactor TestRefundFeesOnChannelClosure #6263

Closed
colin-axner opened this issue May 7, 2024 · 0 comments · Fixed by #6323
Closed

simplify/refactor TestRefundFeesOnChannelClosure #6263

colin-axner opened this issue May 7, 2024 · 0 comments · Fixed by #6323
Labels
help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@colin-axner
Copy link
Contributor

colin-axner commented May 7, 2024 •
edited by crodriguezvega
Loading

might be nice to refactor this test in future to be a bit more clear, maybe we some expResult func or something. But happy to move ahead with this for now

Originally posted by @damiannolan in #6255 (comment)

Refactor this test to improve readability and maintenance. Low priority given it is a lesser used code path and hasn't required many changes to date
@crodriguezvega crodriguezvega added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests labels May 13, 2024
@TropicalDog17 TropicalDog17 mentioned this issue May 16, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor TestRefundFeesOnChannelClosure TropicalDog17/ibc-go
2 participants
@crodriguezvega @colin-axner