bug(ibc-clients/tendermint): sanity check for proof_specs are skipped

[rnbguy]

Bug Summary

The proof_specs for tendermint client state should validate if they have min_depth <= max_depth.

Details

This is the current proof_specs validation.

ibc-rs/ibc-clients/ics07-tendermint/types/src/client_state.rs

Lines 184 to 188 in e048e34

	if self.proof_specs.is_empty() {
	return Err(Error::Validation {
	reason: "ClientState proof-specs cannot be empty".to_string(),
	});
	}

There should be one more check that validates the above inequality. It is best to implement a validate method for ProofSpecs that includes all these checks and use it here.

pub fn validate(&self) -> bool {
  !self.0.is_empty() &&
  self.0.iter().all(|proof_spec| proof_spec.min_depth <= proof_spec.max_depth) 
}

Version

<= 0.50.0

[gr4yha7]

@rnbguy i can take this. One question though: what will be the new validation error reason?

[rnbguy]

Thanks @gr4yha7 ! you can use

format!("Depth range in proof-specs cannot be empty: ({}, {})", proof_spec.min_depth, proof_spec.max_depth)

Note that my validate impl was a reference. Please implement it as following

fn validate(&self) -> Result<(), Error> {
  if self.0.is_empty() { return Err(...); }
  for proof_spec in &self.0 {
    if proof_spec.min_depth >  proof_spec.max_depth { return Err(...); } 
  }
  Ok(())
}

[gr4yha7]

@rnbguy I added a PR.