Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability to validate client substitute when recovering a client #1110

Closed
Tracked by #738
seanchen1991 opened this issue Feb 29, 2024 · 0 comments · Fixed by #1127
Closed
Tracked by #738

Implement ability to validate client substitute when recovering a client #1110

seanchen1991 opened this issue Feb 29, 2024 · 0 comments · Fixed by #1127
Assignees
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Feb 29, 2024

Problem Statement

As part of implementing ADR-026 in ibc-rs, a frozen/expired client is recovered by updating it to match a substitute client.

Before the actual client recovery process can proceed, the substitute client must be validated to ensure that it:

  1. is the same type as the subject client
  2. matches all of the same parameters as the subject client, i.e., that the frozen height, latest height, and chain ID all match

Proposal

A new method check_substitute is added to the ClientStateValidation trait.

@seanchen1991 seanchen1991 changed the title Implement ability to validate client substitute when recovering a client (feat) Implement ability to validate client substitute when recovering a client Feb 29, 2024
@seanchen1991 seanchen1991 changed the title (feat) Implement ability to validate client substitute when recovering a client Implement ability to validate client substitute when recovering a client Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Mar 26, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Apr 3, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.52.0 milestone Apr 4, 2024
@seanchen1991 seanchen1991 self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants