[ICS07] Header/Misbehaviour verification methods are not quite reusable

[Farhad-Shabani]

Improvement Summary

Currently, some functions/methods handling ICS07 Header/Misbehaviour verification are closely tied to specific Tendermint's ClientState and ConsensusState types. However, these functions could be made more versatile to benefit other structures resembling ICS07 without requiring all their fields. These methods include:

• check_trusted_next_validator_set
• as_trusted_block_state
• verify_misbehaviour_header
• check_for_misbehaviour_on_misbehavior
• check_trusted_next_validator_set

Proposal

Typically, these methods don't need the entire object (all fields) of the ClientState and ConsensusState. The idea is to flatten the arguments of these functions by passing only the essential information they require. This approach allows us to work with different types of ClientState that share similar verification logic. This need became apparent while implementing the verify_client_message and check_misbehavior methods for the Sovereign light client in the sovereign-ibc.