-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ICS008 wrapper type for host client and consensus state #1237
Comments
Maybe we can add another generic associated type to ibc-rs/ibc-core/ics24-host/src/context.rs Lines 28 to 31 in 2378cd4
type HostClientStateAtCounterparty<V>: Into<V> + TryFrom<Any> where V: TryFrom<Any>; And, later, we use it as:: Ctx::HostClientStateAtCounterparty<Ctx::HostClientState>::try_from(
msg.client_state_of_a_on_b.clone()
)
.map_err(Into::into)?
.into(); This way, we allow the crate users to build their own custom host client wrapper. |
Looks like, the similar is required for host consensus state. In the following, we need to wrap the consensus state in wasm consensus state and then check for proofs. ibc-rs/ibc-core/ics03-connection/src/handler/conn_open_ack.rs Lines 119 to 120 in 2378cd4
ibc-rs/ibc-core/ics03-connection/src/handler/conn_open_try.rs Lines 115 to 116 in 2378cd4
|
Feature Summary
Now that ibc-go comes with wasm-08, client state of an ibc-rs chain maybe stored as wasm wrapped format in wasm-08 enabled chain.
So when
MsgConnectionOpenTry
orMsgConnectionOpenAck
is received at ibc-rs, it should expect two cases:Proposal
We need to introduce an enum:
Then, use
HosClientState<Ctx::HostClientState>
in the following places:ibc-rs/ibc-core/ics03-connection/src/handler/conn_open_ack.rs
Line 52 in 2378cd4
ibc-rs/ibc-core/ics03-connection/src/handler/conn_open_try.rs
Line 42 in 2378cd4
The text was updated successfully, but these errors were encountered: