Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PacketError type into ChannelError #1339

Closed
seanchen1991 opened this issue Sep 16, 2024 · 0 comments · Fixed by #1343 or #1350
Closed

Merge PacketError type into ChannelError #1339

seanchen1991 opened this issue Sep 16, 2024 · 0 comments · Fixed by #1343 or #1350
Assignees
Milestone

Comments

@seanchen1991
Copy link
Contributor

Feature Summary

ibc-rs's top-level error type contains two distinct ICS04 variants, ChannelError and PacketError. This is a discrepancy from the rest of the variants that exist in this error type, as every other variant captures all the errors that originate from a single module. This discrepancy should be cleaned up by merging ChannelError and PacketError into a single type.

Proposal

Merge the PacketError type into ChannelError by moving the relevant PacketError variants into ChannelError. We'll opt to do this instead of simply adding an Packet(PacketError) variant under ChannelError in order to avoid unnecessary enum nesting.

@seanchen1991 seanchen1991 added this to the 0.55.0 milestone Sep 16, 2024
@seanchen1991 seanchen1991 self-assigned this Sep 16, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Sep 16, 2024
@seanchen1991 seanchen1991 moved this from 📥 To Do to 🔖 Needs Review in ibc-rs Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Needs Review to ✅ Done in ibc-rs Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant