Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_check_header_and_update should return None if consensus state not found #405

Closed
Farhad-Shabani opened this issue Feb 9, 2023 · 0 comments · Fixed by #406
Closed

new_check_header_and_update should return None if consensus state not found #405

Farhad-Shabani opened this issue Feb 9, 2023 · 0 comments · Fixed by #406
Assignees
@Farhad-Shabani
Labels
A: bug Admin: something isn't working

Comments

@Farhad-Shabani
Copy link
Member

Bug Summary

  • The update client validation step under the val_exec_ctx feature fails, because of an issue with the new_check_header_and_update_state() method. The error variant of consensus_state (here) should return None if the consensus state is not found.
  • This was caught while testing with basecoin-rs
@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label Feb 9, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 9, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 9, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🔖 Needs Review in ibc-rs Feb 9, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 9, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 🔖 Needs Review to ✅ Done in ibc-rs Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: bug Admin: something isn't working
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with the error variant of new_check_header_and_update method cosmos/ibc-rs
1 participant
@Farhad-Shabani