Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code clarity by adding docs and renaming params around "validate_self_client" method #434

Closed
Farhad-Shabani opened this issue Feb 15, 2023 · 0 comments · Fixed by #436
Assignees
Labels
O: code-hygiene Objective: aims to improve code hygiene S: docs Scope: improvements or additions to documentation
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

During a discussion in issue #384, it was brought to our attention that the concept of "validate_self_client" is somewhat difficult to understand, and would benefit from clearer documentation or namings to guide users in the right direction

@Farhad-Shabani Farhad-Shabani added S: docs Scope: improvements or additions to documentation O: code-hygiene Objective: aims to improve code hygiene labels Feb 15, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Feb 15, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 15, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🔖 Needs Review in ibc-rs Feb 15, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Needs Review to ✅ Done in ibc-rs Feb 17, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.29.0 milestone Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: code-hygiene Objective: aims to improve code hygiene S: docs Scope: improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant