Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientState: consider replacing confirm_frozen and expired methods with a "status" instead #536

Closed
Tracked by #554
Farhad-Shabani opened this issue Mar 15, 2023 · 0 comments · Fixed by #774
Closed
Tracked by #554
Assignees
Labels
O: exploratory Objective: aims to investigate new ideas O: logic Objective: aims for better implementation logic O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

Context: #531 (comment)

Currently, the ClientState trait exposes three interfaces: is_frozen, expired, and frozen_height for checking the client status. However, these methods appear to make some underlying assumptions about the characteristics of the host chain.
Further investigation is required to ensure their compatibility with any chains. To address this issue, it is suggested that we adopt the approach taken by IBC-go, which provides a more practical and robust status() API.

@Farhad-Shabani Farhad-Shabani added O: usability Objective: aims to enhance user experience (UX) and streamline product usability O: logic Objective: aims for better implementation logic labels Mar 15, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Mar 15, 2023
@Farhad-Shabani Farhad-Shabani changed the title [ICS02] Investigate more chain-neutral interface instead of is_frozen and expired method [ICS02] Investigate more chain-neutral interface instead of is_frozen and expired methods Mar 16, 2023
@plafer plafer added the O: exploratory Objective: aims to investigate new ideas label Mar 16, 2023
@plafer plafer changed the title [ICS02] Investigate more chain-neutral interface instead of is_frozen and expired methods ClientState: consider replacing confirm_frozen and expired methods with a "status" instead Mar 16, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Aug 4, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.44.0 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: exploratory Objective: aims to investigate new ideas O: logic Objective: aims for better implementation logic O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants