Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_header_and_update_state: missing Header.height() vs Header.trusted_height check #585

Closed
Tracked by #535
plafer opened this issue Mar 30, 2023 · 0 comments · Fixed by #584
Closed
Tracked by #535
Assignees
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Mar 30, 2023

Problem is here.

The tendermint-light-client's verifier doesn't ensure that Header.height() > Header.trusted_height, so we need to make that check in ibc-rs. In words, the trusted height (representing the height of the header already on chain for which this client update is based on) must be smaller than height of the new header that we're installing.

See equivalent check in ibc-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants