Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IbcEventType #623

Closed
plafer opened this issue Apr 14, 2023 · 0 comments · Fixed by #624
Closed

Fix IbcEventType #623

plafer opened this issue Apr 14, 2023 · 0 comments · Fixed by #624
Assignees
Labels
A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Apr 14, 2023

The current assumption in our events is that each variant of IbcEvent has one and only one "event type" (which eventually makes it to the abci::Event::kind field). This is not true for IbcEvent::AppModule. For example, only in the token transfer app, it can have types ibc_transfer, fungible_token_packet, etc.

In order to fix this, we should

  1. Remove IbcEventType (since not all event types are known by ibc-core)
  2. let each event variant define its own event type
@plafer plafer self-assigned this Apr 14, 2023
@plafer plafer added this to ibc-rs Apr 14, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in ibc-rs Apr 20, 2023
@Farhad-Shabani Farhad-Shabani added A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability labels Apr 20, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.38.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants