Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS07] try_from RawClientState conversion should exclude ClientState::new checks #671

Closed
Farhad-Shabani opened this issue May 10, 2023 · 0 comments · Fixed by #673
Closed
Assignees
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

It is possible that MsgUpgradeClient contains a valid ClientState, but it won't necessarily pass checks within ClientState::new() when parsed from Any. E.g. trust_level might be zero, see how Hermes creates the ClientState for an upgrade proposal.

The ClientState validity checks for the upgrade_client must be done only after a new_client_state is built within the update_state_with_upgrade_client process

@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs May 10, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this May 10, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs May 11, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.41.0 milestone May 11, 2023
@Farhad-Shabani Farhad-Shabani changed the title try_from RawClientState conversion should exclude ClientState::new checks [ICS07] try_from RawClientState conversion should exclude ClientState::new checks May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant