Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientState::verify_upgrade_client uses the wrong MerkleProof type #691

Closed
plafer opened this issue May 25, 2023 · 0 comments · Fixed by #692
Closed

ClientState::verify_upgrade_client uses the wrong MerkleProof type #691

plafer opened this issue May 25, 2023 · 0 comments · Fixed by #692
Milestone
v0.42.0

Comments

@plafer
Copy link
Contributor

plafer commented May 25, 2023

We currently use the raw type; we should use the domain type ibc::core::ics23_commitment::merkle::MerkleProof
@Farhad-Shabani Farhad-Shabani mentioned this issue May 25, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs May 25, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.42.0 milestone May 25, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.42.0
Development

Successfully merging a pull request may close this issue.

Revise verify_upgrade_client to utilize domain MerkleProof type cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani