Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS 004: SendPacket interface should return the packet sequence #819

Closed
colin-axner opened this issue Aug 15, 2022 · 1 comment · Fixed by #922
Closed

ICS 004: SendPacket interface should return the packet sequence #819

colin-axner opened this issue Aug 15, 2022 · 1 comment · Fixed by #922
Labels
tao Transport, authentication, & ordering layer.

Comments

@colin-axner
Copy link
Contributor

SendPacket now gets the next send sequence and includes it in the packet as the packet sequence. Applications calling this function will not know which sequence belongs to a SendPacket call unless the sequence is returned. Thus, I recommend that the packet sequence be returned in a SendPacket call. This is analogous to sending a package and receiving a tracking number
@colin-axner colin-axner mentioned this issue Aug 15, 2022
Merged
4 tasks
@colin-axner colin-axner changed the title ICS 004: SendPacket interface should returnt the packet sequence ICS 004: SendPacket interface should return the packet sequence Aug 15, 2022
@crodriguezvega crodriguezvega added the tao Transport, authentication, & ordering layer. label Aug 16, 2022
@crodriguezvega crodriguezvega moved this to Todo in IBC specs Aug 16, 2022
@crodriguezvega
Copy link
Contributor

I believe when this PR is merged ibc-go will have implemented this, so it will be ahead of the spec.

@crodriguezvega crodriguezvega mentioned this issue Jan 27, 2023
Merged
@crodriguezvega crodriguezvega linked a pull request Jan 27, 2023 that will close this issue
ICS 04: return sequence number in sendPacket #922
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in IBC specs Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tao Transport, authentication, & ordering layer.
Projects
IBC-GO Eureka
Status: Backlog
IBC specs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ICS 04: return sequence number in sendPacket cosmos/ibc
2 participants
@crodriguezvega @colin-axner