Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the consumer chain state on removal #125

Closed
1 task done
mpoke opened this issue Jun 6, 2022 · 3 comments · Fixed by #268
Closed
1 task done

Cleanup the consumer chain state on removal #125

mpoke opened this issue Jun 6, 2022 · 3 comments · Fixed by #268
Assignees
@sainoe

Comments

@mpoke
Copy link
Contributor

mpoke commented Jun 6, 2022 •
edited
Loading

The consumer chain state (i.e., see all the setters in keeper/keeper.go) must be cleaned up when the consumer chain halts (see BeginBlock() on consumer chain). This will enable the halted consumer chain to be restarted either as a consumer chain (by sending another gov proposal to the provider chain) or as a normal chain.
@mpoke mpoke added the ccv-core label Jun 6, 2022
@mpoke mpoke moved this to Todo in Replicated Security Jun 6, 2022
@mpoke mpoke mentioned this issue Jun 17, 2022
Closed
@mpoke
Copy link
Contributor Author

mpoke commented Jun 20, 2022 •
edited by danwt
Loading

Issue related:

@mpoke mpoke mentioned this issue Jun 21, 2022
Closed
@danwt danwt self-assigned this Jun 26, 2022
@danwt danwt moved this from Todo to Next in Replicated Security Jun 26, 2022
@danwt danwt moved this from Next to Todo in Replicated Security Jul 4, 2022
@mpoke
Copy link
Contributor Author

mpoke commented Aug 11, 2022

See TODO in StopConsumerChain()

@sainoe sainoe mentioned this issue Aug 12, 2022
Merged
@mpoke mpoke assigned sainoe and unassigned danwt Aug 23, 2022
@mpoke mpoke moved this from Todo to Waiting for review in Replicated Security Aug 23, 2022
@jtremback
Copy link
Contributor

I don't think this is a good idea anymore, see #268 (comment)

Repository owner moved this from Waiting for review to Done in Replicated Security Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
None yet
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup states after consumer chain removal cosmos/interchain-security
4 participants
@jtremback @mpoke @sainoe @danwt