Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No query for oldest unconfirmed VSCPacket #1263

Closed
mpoke opened this issue Sep 5, 2023 · 3 comments · Fixed by #1740
Closed

No query for oldest unconfirmed VSCPacket #1263

mpoke opened this issue Sep 5, 2023 · 3 comments · Fixed by #1740
Assignees
@mpoke
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability scope: UI Addressing UX changes and improvements to user interface

Comments

@mpoke
Copy link
Contributor

mpoke commented Sep 5, 2023

Problem

Currently there is no possibility to query the oldest sent VSCPacket for which the equivalent VSCMaturedPackets were not received from all consumer chains. This info is needed to estimate the time until a consumer chain will be removed due to the VSCTimeout.

Closing criteria

Add a query that returns the vsc send timestamp with the lowest vscID for the given chainID, i.e., GetFirstVscSendTimestamp.
@mpoke mpoke added good first issue Good for newcomers scope: UI Addressing UX changes and improvements to user interface labels Sep 5, 2023
@mpoke mpoke added this to Cosmos Hub Sep 5, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 5, 2023
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 5, 2023
@mpoke mpoke added the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Sep 5, 2023
@neitdung
Copy link
Contributor

neitdung commented Dec 9, 2023

Could I take this issue sir, @mpoke?

@neitdung
Copy link
Contributor

neitdung commented Dec 9, 2023 •
edited
Loading

After investigation, I've found function has been implemented at here: GetFirstVscSendTimestamp function. So, I think we should close this issue

@MSalopek
Copy link
Contributor

MSalopek commented Feb 2, 2024 •
edited
Loading

The issue should not be closed since it states that there is no query to extract the information needed.

Add a query that returns the vsc send timestamp with the lowest vscID for the given chainID, i.e., GetFirstVscSendTimestamp.

The gRPC/API and CLI query should return the information contained in the GetFirstVscSendTimestamp response.

@mpoke mpoke self-assigned this Mar 28, 2024
@mpoke mpoke moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Mar 28, 2024
@mpoke mpoke mentioned this issue Mar 28, 2024
Merged
21 tasks
@mpoke mpoke moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Mar 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Apr 2, 2024
This was referenced Apr 2, 2024
Merged
Merged
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpoke mpoke

Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability scope: UI Addressing UX changes and improvements to user interface
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add oldest_unconfirmed_vsc query cosmos/interchain-security
3 participants
@mpoke @MSalopek @neitdung