Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comet/cometmock discrepancy w.r.t downtime related e2e tests #1304

Closed
shaspitz opened this issue Sep 14, 2023 · 2 comments
Closed

comet/cometmock discrepancy w.r.t downtime related e2e tests #1304

shaspitz opened this issue Sep 14, 2023 · 2 comments
Assignees
@p-offtermatt
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@shaspitz
Copy link
Contributor

Problem

The throttling e2e tests illuminated a difference in behavior between comet and cometmock. Namely, relaying packets behaves differently. For real comet, a slash action followed by a relay action will only relay the slash packet, whereas for cometmock a slash action followed by a relay action will relay the slash packet, and the corresponding vsc packet derived from the vp change.

CC @p-offtermatt

Closing criteria

Find and fix behavior discrepancy

Problem details
@shaspitz shaspitz added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Sep 14, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 14, 2023
@shaspitz shaspitz mentioned this issue Sep 14, 2023
Closed
8 tasks
@shaspitz shaspitz changed the title comet/cometmock discrepancy w.r.t throttling e2e tests comet/cometmock discrepancy w.r.t downtime related e2e tests Sep 14, 2023
@shaspitz
Copy link
Contributor Author

@p-offtermatt see 1ed2f56, #1230 now passes make test-e2e-short, make test-e2e-short-cometmock and go run ./tests/e2e/... --tc slash-throttle. Running the slash throttle test case with cometmock will fail, but that's not a part of CI

@shaspitz shaspitz mentioned this issue Sep 14, 2023
Merged
20 tasks
@p-offtermatt
Copy link
Contributor

Thanks for opening the issue and giving the context Shawn!

@p-offtermatt p-offtermatt added scope: testing Code review, testing, making sure the code is following the specification. S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Sep 15, 2023
@p-offtermatt p-offtermatt self-assigned this Sep 15, 2023
@p-offtermatt p-offtermatt moved this from 🩹 F1: Triage to 🤔 F1: Investigate in Cosmos Hub Sep 15, 2023
@p-offtermatt p-offtermatt moved this from 🤔 F1: Investigate to 📥 F2: Todo in Cosmos Hub Oct 10, 2023
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Jun 11, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-offtermatt p-offtermatt

Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaspitz @p-offtermatt