Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depreciated Proto Package #236

Closed
shaspitz opened this issue Jul 14, 2022 · 2 comments
Closed

Depreciated Proto Package #236

shaspitz opened this issue Jul 14, 2022 · 2 comments
Labels
type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run

Comments

@shaspitz
Copy link
Contributor

While fixing up the golangci-lint errors in #235, it was found that the proto package used in proposal_test.go is depreciated.

Attempting to use the suggested google.golang.org/protobuf/proto package url disallows the file from being compiled, since the newer version of proto.Equal requires that types.CreateConsumerChainProposal implements ProtoReflect.

It seems that we need to compile pb files using a newer version of protoc. Maybe there's an easy solution that I'm missing, but it doesn't seem as easy as changing a version number in the makefile.

Most relevant PR I could find for the issue: #92

@marbar3778 Any ideas here?
@shaspitz shaspitz mentioned this issue Jul 14, 2022
Merged
@danwt danwt added type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run labels Jul 15, 2022
@danwt danwt moved this to Todo in Replicated Security Jul 15, 2022
@tac0turtle
Copy link
Member

the cosmos ecosystem still uses go proto APIv1, protoreflect it API v2. We are working towards migrating but for now we have to either use gogo/proto or the old library for gloat protobuf

@jtremback
Copy link
Contributor

Should this issue be closed @marbar3778 @smarshall-spitzbart ? It sounds like a wontfix

Repository owner moved this from Todo to Done in Replicated Security Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jtremback @tac0turtle @danwt @shaspitz