Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests confirming that pb schema mismatch between consumer/provider is safe #790

Closed
Tracked by #756
shaspitz opened this issue Mar 17, 2023 · 1 comment
Closed
Tracked by #756

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Mar 17, 2023

In #757, the ccv consumer genesis state schema will be mutated by adding the this bool. That schema is used on the provider and consumer. So for some amount of time before we make a MAJOR version bump to ICS, including provider changes, the provider and consumer will use a mismatched protobuf schema. It doesn't seem like this will cause any issues as genesis state is spit out as a JSON. But this topic is worth exploring

@mpoke mpoke added the question label Mar 17, 2023
@mpoke mpoke added this to Cosmos Hub Mar 17, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Mar 17, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Mar 17, 2023
@shaspitz
Copy link
Contributor Author

Closing this as a non-issue. The consumer genesis state is queried from the provider as a JSON (see link)

cmd := exec.Command("docker", "exec", tr.containerConfig.instanceName, tr.chainConfigs[action.providerChain].binaryName,
and we can leave it up to the responsibility of consumer team(s) to correctly mutate that JSON to match the correct schema of the consumer

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Cosmos Hub Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants