Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonded stake value is too long on LiValidator #1449

Closed
faboweb opened this issue Oct 10, 2018 · 7 comments
Closed

Bonded stake value is too long on LiValidator #1449

faboweb opened this issue Oct 10, 2018 · 7 comments
Assignees
@jbibla
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Oct 10, 2018

UI Version: 0.10.6

Description:

image
@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Oct 10, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 10, 2018

What should happen instead here?

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 10, 2018

Either shorten the value, increase the size of the field or come up with a different design where tokens have a lote more space. Do you have any idea?

@fedekunze
Copy link
Contributor

lol I raised this issue on the PR review

@jbibla
Copy link
Collaborator

jbibla commented Oct 10, 2018

aw 😭 sorry guys.

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 11, 2018

In this case I think it's appropriate to round the amount.

@jbibla
Copy link
Collaborator

jbibla commented Oct 11, 2018 •
edited
Loading

i've been thinking lately that we should round to 4 decimal places everywhere but show full decimals in all form fields for making accurate transactions.

about this specific bug / screenshot above - this can be fixed with css too. the size of the boxes shouldn't change when the app window size changes since we aren't actually supporting full responsiveness.

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 17, 2018

Scope:

  • create shortNumber function that rounds to 4 decimals
  • user shortNumber in all places with limited space

@NodeGuy NodeGuy assigned fedekunze and unassigned faboweb Oct 23, 2018
@jbibla jbibla mentioned this issue Oct 24, 2018
Merged
2 tasks
@NodeGuy NodeGuy removed high priority ❗ low priority has been discussed, will be addressed later labels Oct 30, 2018
This was referenced Nov 13, 2018
Merged
Merged
Merged
Merged
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NodeGuy @faboweb @jbibla @fedekunze