Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all vuex modules need to track loading in the state #1566

Closed
jbibla opened this issue Nov 13, 2018 · 3 comments · Fixed by #1593 or #1608
Closed

all vuex modules need to track loading in the state #1566

jbibla opened this issue Nov 13, 2018 · 3 comments · Fixed by #1593 or #1608
Assignees
Labels
design-work-needed 🎨 issues that require design work before development refactor

Comments

@jbibla
Copy link
Collaborator

jbibla commented Nov 13, 2018

before:

const state = {
    blockMetaInfo: { block_id: {} },
    blockHeight: null, // we remember the height so we can requery the block, if querying failed
    subscription: false,
    syncing: true,
    blockMetas: {},
    subscribedRPC: null
}

after:

const state = {
    blockMetaInfo: { block_id: {} },
    blockHeight: null, // we remember the height so we can requery the block, if querying failed
    subscription: false,
    syncing: true,
    blockMetas: {},
    subscribedRPC: null,
    loading: false
}

this should then be reflected in the components that use these vuex modules.

@faboweb faboweb self-assigned this Nov 13, 2018
@faboweb faboweb added design-work-needed 🎨 issues that require design work before development refactor labels Nov 13, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 16, 2018

as of @jbibla proposal let's also track the error message if loading failed

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 16, 2018

yes! every try needs a catch! is there a way to enforce this? i tried looking this up in eslint.

@faboweb
Copy link
Collaborator

faboweb commented Nov 17, 2018

You mean sth like https://eslint.org/docs/rules/no-empty ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development refactor
Projects
None yet
2 participants