Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProposalModal Amount bug #1707

Closed
sabau opened this issue Dec 5, 2018 · 3 comments · Fixed by #1763 or #1808
Closed

ProposalModal Amount bug #1707

sabau opened this issue Dec 5, 2018 · 3 comments · Fixed by #1763 or #1808
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@sabau
Copy link
Contributor

sabau commented Dec 5, 2018

Description:

  • I can't find a way to choose from which coin I want to Deposit
  • Once I have 0 Steaks available the UI let me create a proposal with 1 steak anyway, then an error is thrown (which is OK i think)

Here the response:
proposalCreation.txt

and the error:
screen shot 2018-12-05 at 19 03 43

@sabau
Copy link
Contributor Author

sabau commented Dec 5, 2018

I would touch this logic that define a valid amount:

  • between: between(1, this.balance > 0 ? this.balance : 1)

@fedekunze
Copy link
Contributor

we should check that we're sending the coins specified on the min deposit (available through the governance parameters)

@fedekunze fedekunze added bug 🐛 issues related to unhandled errors in the code that need to be fixed high priority ❗ governance-1 🗳️ and removed high priority ❗ labels Dec 6, 2018
@jbibla
Copy link
Collaborator

jbibla commented Dec 6, 2018

@sabau

I can't find a way to choose from which coin I want to Deposit

i think this is expected - should only be steak (for now) - and atoms (in the future) - and other tokens in the future if and when governance permits them

Once I have 0 Steaks available the UI let me create a proposal with 1 steak anyway, then an error is thrown (which is OK i think)

i think our approach is to disable the button and add a tooltip if you are not able to do the action (being addressed in #1601)

also, that error message could use some love 😆


@fedekunze

we should check that we're sending the coins specified on the min deposit

definitely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
3 participants