Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lacking support for hcl in general (variable types) #5

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

malud
Copy link
Collaborator

@malud malud commented Nov 2, 2020

Since we have no own capture groups defined we should use the hcl syntaxes as starting point.
Variable highlighting is a hcl build in feature.

@malud malud requested a review from filex November 2, 2020 06:56
Marcel Ludwig and others added 2 commits November 2, 2020 10:20
Since we have no own capture groups defined we should use the hcl syntaxes as starting point.
Variable highlighting is a hcl build in feature.
@filex filex force-pushed the support-hcl-syntax branch from eb63cd6 to e5417e1 Compare November 2, 2020 10:10
Copy link

@filex filex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok

underlying hcl highlighting support is now much better.

@filex filex merged commit efc8e81 into master Nov 2, 2020
@filex filex deleted the support-hcl-syntax branch November 2, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants