Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apikeys): implement the base paths for the api keys resource #22

Merged
merged 5 commits into from
Oct 17, 2019
Merged

feat(apikeys): implement the base paths for the api keys resource #22

merged 5 commits into from
Oct 17, 2019

Conversation

rosalie-liu
Copy link
Contributor

No description provided.

@rosalie-liu rosalie-liu requested a review from a team October 15, 2019 21:04
@rosalie-liu rosalie-liu self-assigned this Oct 15, 2019
gdostie
gdostie reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@gdostie gdostie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the new api keys resource to the platform object in the file platform-client/src/resources/PlatformResources.ts

src/resources/ApiKeys/ApiKeys.ts Outdated
return this.api.get<ApiKeyModel[]>(ApiKey.baseUrl);
}

toggle(apiKey: ApiKeyModel, options?: {}) {

This comment was marked as resolved.

Sign in to view

src/resources/ApiKeys/ApiKeysInterfaces.ts Show resolved Hide resolved
src/resources/ApiKeys/ApiKeys.ts
import Resource from '../Resource';
import {ApiKeyModel} from './ApiKeysInterfaces';

export default class ApiKey extends Resource {

This comment was marked as resolved.

Sign in to view

gdostie
gdostie reviewed Oct 17, 2019
View reviewed changes
src/resources/ApiKeys/ApiKeysInterfaces.ts Outdated
resourceId?: string;
}

export enum Provider {

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

src/resources/ApiKeys/ApiKeysInterfaces.ts Outdated
OTHER = 'OTHER',
}

export interface IdAndDisplayNameModel {

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

src/resources/ApiKeys/ApiKeysInterfaces.ts Outdated
displayName?: string;
}

export interface PrivilegeModel {

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

gdostie
gdostie approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@gdostie gdostie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! you could squash and merge so that the git history remains clean 😄 I you do, you will still need to write a commit message that respects the commit message convention

@rosalie-liu rosalie-liu merged commit 8796b09 into master Oct 17, 2019
@rosalie-liu rosalie-liu deleted the ADUI-4792/add-api-keys-resource branch October 17, 2019 16:23
@gdostie
Copy link
Contributor

gdostie commented Oct 17, 2019

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredboutin fredboutin fredboutin left review comments

@gdostie gdostie gdostie approved these changes

@pochretien pochretien pochretien approved these changes

@GermainBergeron GermainBergeron Awaiting requested review from GermainBergeron

@dmgauthier dmgauthier Awaiting requested review from dmgauthier

@salvarez07 salvarez07 Awaiting requested review from salvarez07

Assignees

@rosalie-liu rosalie-liu

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rosalie-liu @gdostie @pochretien @fredboutin