Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add api key template api call for usage panel #851

Merged
merged 13 commits into from
Sep 5, 2024
Merged

feat: add api key template api call for usage panel #851

merged 13 commits into from
Sep 5, 2024

Conversation

schaoukicoveo
Copy link
Contributor

@schaoukicoveo schaoukicoveo commented Aug 26, 2024 •
edited
Loading

J:ORG-659

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@schaoukicoveo schaoukicoveo marked this pull request as ready for review August 28, 2024 02:28
@schaoukicoveo schaoukicoveo requested review from a team as code owners August 28, 2024 02:28
gdostie
gdostie reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@gdostie gdostie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resources hasn't been instantiated on the platform client class, so it won't be accessible from it (ex: Platform.apiKeyTemplate)

src/resources/ApiKeyTemplate/test/ApiKeyTemplate.spec.ts Outdated Show resolved Hide resolved
src/resources/ApiKeyTemplate/ApiKeyTemplateInterface.ts Outdated Show resolved Hide resolved
src/resources/ApiKeyTemplate/index.ts Outdated Show resolved Hide resolved
@schaoukicoveo
Copy link
Contributor Author

The resources hasn't been instantiated on the platform client class, so it won't be accessible from it (ex: Platform.apiKeyTemplate)

Perfect will add it right now

@schaoukicoveo schaoukicoveo added this pull request to the merge queue Sep 5, 2024
Merged via the queue into master with commit 2375f77 Sep 5, 2024
5 checks passed
@schaoukicoveo schaoukicoveo deleted the feature/ORG-659 branch September 5, 2024 18:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

🎉 This issue has been resolved in version 55.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@gdostie gdostie gdostie approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier dmgauthier is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaoukicoveo @gdostie @alexprudhomme