Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new attributes to api key model #857

Merged
merged 8 commits into from
Sep 30, 2024
Merged

feat: add new attributes to api key model #857

merged 8 commits into from
Sep 30, 2024

Conversation

schaoukicoveo
Copy link
Contributor

J:ORG-666

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@schaoukicoveo schaoukicoveo requested review from a team as code owners September 23, 2024 15:43
fbeaudoincoveo
fbeaudoincoveo requested changes Sep 25, 2024
View reviewed changes
src/resources/ApiKeys/ApiKeysInterfaces.ts Outdated Show resolved Hide resolved
src/resources/ApiKeys/ApiKeysInterfaces.ts Outdated Show resolved Hide resolved
src/resources/ApiKeys/ApiKeysInterfaces.ts Outdated Show resolved Hide resolved
src/resources/Enums.ts Outdated Show resolved Hide resolved
schaoukicoveo and others added 5 commits September 25, 2024 14:01
@schaoukicoveo @fbeaudoincoveo
Update ApiKeysInterfaces.ts
4d784e9 
Co-authored-by: Frederic Beaudoin <[email protected]>
@schaoukicoveo @fbeaudoincoveo
Update ApiKeysInterfaces.ts
7cc634d 
Co-authored-by: Frederic Beaudoin <[email protected]>
@schaoukicoveo @fbeaudoincoveo
Update ApiKeysInterfaces.ts
e06251c 
Co-authored-by: Frederic Beaudoin <[email protected]>
@schaoukicoveo @fbeaudoincoveo
Update Enums.ts
bae750c 
Co-authored-by: Frederic Beaudoin <[email protected]>
@schaoukicoveo
chore: apply pr comments
1d7cd6c
@schaoukicoveo schaoukicoveo added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit d9fb78f Sep 30, 2024
5 checks passed
@schaoukicoveo schaoukicoveo deleted the feature/ORG-666 branch September 30, 2024 19:34
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 55.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@schaoukicoveo schaoukicoveo restored the feature/ORG-666 branch October 1, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier dmgauthier is a code owner automatically assigned from coveo/frontend-foundation

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaoukicoveo @fbeaudoincoveo @gdostie