Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add necessary attributes to api key model and fix issue with enum #869

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: add necessary attributes to api key model and fix issue with enum #869

merged 1 commit into from
Oct 1, 2024

Conversation

schaoukicoveo
Copy link
Contributor

@schaoukicoveo schaoukicoveo commented Oct 1, 2024 •
edited
Loading

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@schaoukicoveo schaoukicoveo requested review from a team as code owners October 1, 2024 18:04
@schaoukicoveo schaoukicoveo added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit 6bf06f6 Oct 1, 2024
7 checks passed
@schaoukicoveo schaoukicoveo deleted the fix/ORG-666 branch October 1, 2024 18:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 55.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@aboissinot-coveo aboissinot-coveo Awaiting requested review from aboissinot-coveo aboissinot-coveo is a code owner automatically assigned from coveo/frontend-foundation

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaoukicoveo @GermainBergeron @gdostie