Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export the exposure report interface #903

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

schaoukicoveo
Copy link
Contributor

@schaoukicoveo schaoukicoveo commented Jan 7, 2025

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@mcnoreau12 mcnoreau12 self-requested a review January 7, 2025 21:53
Copy link

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with the repo but don't you need to expose this interface in an index file ?

Copy link
Contributor

@FelixBlaisThon FelixBlaisThon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@schaoukicoveo schaoukicoveo added this pull request to the merge queue Jan 8, 2025
@FelixBlaisThon
Copy link
Contributor

I am not super familiar with the repo but don't you need to expose this interface in an index file ?

Every interfaces are exported in the index.ts file already like so

export * from './ApiKeysInterfaces.js'

So it should be already exported :)

Merged via the queue into master with commit 9571063 Jan 8, 2025
5 checks passed
@schaoukicoveo schaoukicoveo deleted the feature/ORG-911-exposureReport-export branch January 8, 2025 13:47
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 57.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants