fix(atomic): fix atomic react rendering function #1909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple seems to have went wrong:
cra
dependencies. This caused subtle changes to jest setup in headless-react samples, which means we now have to add extra config for JestsetRenderingFunction
in AtomicResultList could be undefined if called beforeinitialize
. I modified it so thatResultListCommon
is always created first, no matter the entry point.🤞
https://coveord.atlassian.net/browse/KIT-1557