feat(atomic): add atomic-result-html component #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamothe
requested review from
ThibodeauJF,
liviarett,
btaillon-coveo and
npushkarskii
|
Thanks for your contribution @olamothe !
|
btaillon-coveo
approved these changes
May 24, 2022
People that want to display field properties from their result which contains HTML. |
ThibodeauJF
reviewed
May 24, 2022
ThibodeauJF
approved these changes
May 24, 2022
npushkarskii
approved these changes
May 24, 2022
...s/atomic/src/components/result-template-components/atomic-result-html/atomic-result-html.tsx
Show resolved
Hide resolved
liviarett
reviewed
May 27, 2022
...s/atomic/src/components/result-template-components/atomic-result-html/atomic-result-html.tsx
Outdated
Show resolved
Hide resolved
liviarett
reviewed
May 27, 2022
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
packages/atomic/cypress/integration/result-list/result-components/result-html.cypress.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two components to output HTML (atomic-html, atomic-result-html), especially useful for results.
Use
DOMPurifyto optionally sanitize the HTML.Also fixed a bug in Headless with highlight function: When there's no highlights (ie: an empty array is passed to the function), it would return the un-escaped value.
https://coveord.atlassian.net/browse/KIT-1122