fix(atomic): fix issue with changing panels while results load #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2022 10:16
|
Thanks for your contribution @liviarett !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
packages/atomic/src/components/atomic-search-box/atomic-search-box.tsx
Outdated
Show resolved
Hide resolved
olamothe
approved these changes
Jun 7, 2022
packages/atomic/src/components/atomic-search-box/atomic-search-box.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/atomic-search-box/atomic-search-box.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/atomic-search-box/atomic-search-box.tsx
Outdated
Show resolved
Hide resolved
added 6 commits
June 8, 2022 11:05
…-fix-issue-with-changing-panels-while-results-load
btaillon-coveo
approved these changes
Jun 8, 2022
ThibodeauJF
approved these changes
Jun 8, 2022
added 2 commits
June 8, 2022 17:03
…-fix-issue-with-changing-panels-while-results-load https://coveord.atlassian.net/browse/KIT-1713
liviarett
deleted the
KIT-1713-atomic-fix-issue-with-changing-panels-while-results-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally managed to reproduce a issue I saw every once in a while - when we change the panel in focus before the elements are updated, it breaks like so:
https://user-images.githubusercontent.com/30511433/172345709-eff01237-1ded-4162-ae92-f0c0b0029cb4.mov
Now, keeping track of the element that triggered the change, we can make sure that we don't update the wrong panel:
https://user-images.githubusercontent.com/30511433/172345889-0f89aacc-f8f1-4000-9325-cd83c97d2b9b.mov
I also took the opportunity to fix a little difference in behaviour between mouse and keyboard focus (before, it lost track of the previous element on mouse over)
https://user-images.githubusercontent.com/30511433/172346033-3decc9a0-63a7-4ed1-ad07-c4d4cc856569.mov