Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(atomic): add explicit types for different types of store #2190

Merged
merged 4 commits into from
Jul 5, 2022
Merged

fix(atomic): add explicit types for different types of store #2190

merged 4 commits into from
Jul 5, 2022

Conversation

olamothe
Copy link
Member

@olamothe olamothe commented Jul 5, 2022

@olamothe olamothe requested review from a team and mbenkirane-coveo as code owners July 5, 2022 19:31
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 201.7 201.7 0
search 293.8 293.8 0
insight 222 222 0
product-listing 214.6 214.6 0
product-recommendation 198 198 0
recommendation 196.7 196.7 0

@olamothe olamothe requested a review from a team as a code owner July 5, 2022 19:54
@olamothe olamothe removed the request for review from a team July 5, 2022 20:16
@olamothe olamothe merged commit 16afb1e into master Jul 5, 2022
@olamothe olamothe deleted the KIT-1824 branch July 5, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibodeauJF ThibodeauJF ThibodeauJF approved these changes

@mbenkirane-coveo mbenkirane-coveo Awaiting requested review from mbenkirane-coveo

@liviarett liviarett Awaiting requested review from liviarett liviarett is a code owner automatically assigned from coveo/search

@btaillon-coveo btaillon-coveo Awaiting requested review from btaillon-coveo btaillon-coveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamothe @ThibodeauJF