From c1e4a5cb24fd64238f9336b05532e84559798959 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Wed, 8 Jan 2025 17:05:40 -0500 Subject: [PATCH 01/11] potential fix --- .../lwc/quanticGeneratedAnswer/templates/generatedAnswer.css | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css index 305794d8819..c50375f85e7 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css @@ -8,6 +8,7 @@ .generated-answer__answer { overflow: hidden; position: relative; + max-height: var(--maxHeight, 250px); } .generated-answer__footer { From cc0dfd430f2e73dee85053b158a285204aa5f45e Mon Sep 17 00:00:00 2001 From: simonmilord Date: Wed, 8 Jan 2025 17:32:56 -0500 Subject: [PATCH 02/11] added empty content css --- .../lwc/quanticGeneratedAnswer/templates/generatedAnswer.css | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css index c50375f85e7..2b8210c9126 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css @@ -9,6 +9,7 @@ overflow: hidden; position: relative; max-height: var(--maxHeight, 250px); + content: ''; } .generated-answer__footer { From c1a9483a08ea70f80e6e30792a5741beba001743 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Tue, 14 Jan 2025 19:12:05 -0500 Subject: [PATCH 03/11] added e2e test --- .../lwc/quanticGeneratedAnswer/e2e/data.ts | 2 +- .../quanticGeneratedAnswer/e2e/pageObject.ts | 8 ++++++ .../e2e/quanticGeneratedAnswer.e2e.ts | 28 ++++++++++++++++++- 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/data.ts b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/data.ts index 4cb61a64aaa..9a67e435b0b 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/data.ts +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/data.ts @@ -3,7 +3,7 @@ const genQaMarkdownTextPayload = { payloadType: 'genqa.messageType', payload: JSON.stringify({ textDelta: - 'Lorem Ipsum is simply dummy text of the printing and typesetting industry.', + 'THIS IS SOME LOREM IPSUM: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin accumsan felis vel nulla venenatis, vel volutpat mauris suscipit. Praesent aliquam, ex et dapibus fermentum, ligula metus condimentum nunc, non vehicula magna magna a nulla. Integer efficitur nunc eget semper facilisis. Quisque nec tortor at nunc blandit dictum sit amet vel mauris. Duis at tellus sit amet mi pharetra tincidunt. Nullam id risus eget risus accumsan molestie ac quis velit. Vivamus consectetur nisi vel enim finibus, nec laoreet risus facilisis. Integer a lacinia ligula. Etiam cursus urna nisi, ut tincidunt elit consectetur quis. Pellentesque nec sem vel neque malesuada euismod vitae nec augue. Suspendisse non ligula eu purus posuere dictum quis et magna. Curabitur dignissim, magna non feugiat consectetur, lorem orci fringilla sapien, sit amet vehicula eros nulla eget enim. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin accumsan felis vel nulla venenatis, vel volutpat mauris suscipit. Praesent aliquam, ex et dapibus fermentum, ligula metus condimentum nunc, non vehicula magna magna a nulla. Integer efficitur nunc eget semper facilisis. Quisque nec tortor at nunc blandit dictum sit amet vel mauris. Duis at tellus sit amet mi pharetra tincidunt. Nullam id risus eget risus accumsan molestie ac quis velit. Vivamus consectetur nisi vel enim finibus, nec laoreet risus facilisis. Integer a lacinia ligula. Etiam cursus urna nisi, ut tincidunt elit consectetur quis. Pellentesque nec sem vel neque malesuada euismod vitae nec augue. Suspendisse non ligula eu purus posuere dictum quis et magna. Curabitur dignissim, magna non feugiat consectetur, lorem orci fringilla sapien, sit amet vehicula eros nulla eget enim.', }), finishReason: 'COMPLETED', }; diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts index 0e303abad5c..e2141571155 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts @@ -63,6 +63,10 @@ export class GeneratedAnswerObject { .locator('.citation__link'); } + get showMoreButton(): Locator { + return this.page.getByTestId('generated-answer__answer-toggle'); + } + async hoverOverCitation(index: number): Promise { // waiting 500ms to allow the component to render completely, cause any re-rendering abort the hover action. await this.page.waitForTimeout(500); @@ -223,6 +227,10 @@ export class GeneratedAnswerObject { return uaRequest; } + async waitForFewSeconds() { + await this.page.waitForTimeout(3000); + } + async waitForGeneratedAnswerCustomUaAnalytics( eventValue: string, customChecker?: Function diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts index 929658d2e0c..8f53f9cf2e9 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts @@ -1,4 +1,4 @@ -import {testSearch, testInsight} from './fixture'; +import {testSearch, testInsight, expect} from './fixture'; import {useCaseTestCases} from '../../../../../../playwright/utils/useCase'; import genQaData from './data'; @@ -174,5 +174,31 @@ useCaseTestCases.forEach((useCase) => { }); }); }); + + test.describe + .only('when the answer is generated in a single shot and the answer exceeds the maximum height', () => { + test.use({ + options: { + collapsible: true, + }, + }); + test('should display the answer as collapsed', async ({ + generatedAnswer, + }) => { + await generatedAnswer.waitForStreamEndUaAnalytics(); + await generatedAnswer.waitForFewSeconds(); + const likeAnalyticRequestPromise = + generatedAnswer.waitForLikeGeneratedAnswerUaAnalytics(); + await generatedAnswer.clickLikeButton(); + await likeAnalyticRequestPromise; + + const showMoreButton = generatedAnswer.showMoreButton; + expect(showMoreButton).not.toBeNull(); + + const showMoreButtonLabel = await showMoreButton.textContent(); + expect(showMoreButtonLabel).not.toBeNull(); + expect(showMoreButtonLabel).toEqual('Show more'); + }); + }); }); }); From fa4d3004c0e5e06bdd3346a313c94730028fc899 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Thu, 16 Jan 2025 10:50:07 -0500 Subject: [PATCH 04/11] fix with custom event --- .../e2e/quanticGeneratedAnswer.e2e.ts | 8 ++------ .../quanticGeneratedAnswer.js | 20 ++++++++++++++----- .../templates/generatedAnswer.html | 1 + .../quanticGeneratedAnswerContent.js | 2 ++ 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts index 8f53f9cf2e9..2a57a0e8d5a 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts @@ -185,19 +185,15 @@ useCaseTestCases.forEach((useCase) => { test('should display the answer as collapsed', async ({ generatedAnswer, }) => { + const expectedShowMoreLabel = 'Show more'; await generatedAnswer.waitForStreamEndUaAnalytics(); - await generatedAnswer.waitForFewSeconds(); - const likeAnalyticRequestPromise = - generatedAnswer.waitForLikeGeneratedAnswerUaAnalytics(); - await generatedAnswer.clickLikeButton(); - await likeAnalyticRequestPromise; const showMoreButton = generatedAnswer.showMoreButton; expect(showMoreButton).not.toBeNull(); const showMoreButtonLabel = await showMoreButton.textContent(); expect(showMoreButtonLabel).not.toBeNull(); - expect(showMoreButtonLabel).toEqual('Show more'); + expect(showMoreButtonLabel).toEqual(expectedShowMoreLabel); }); }); }); diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js index 0f07971777e..0212bc95f10 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js @@ -153,11 +153,7 @@ export default class QuanticGeneratedAnswer extends LightningElement { if (this.collapsible) { // If we are still streaming add a little extra height to the answer element to account for the next answer chunk. // This helps a lot with the jankyness of the answer fading out when the chunk is close but not yet over the max height. - const answerElementHeight = this.isStreaming - ? this.generatedAnswerElementHeight + 50 - : this.generatedAnswerElementHeight; - this._exceedsMaximumHeight = - answerElementHeight > this._maximumAnswerHeight; + this._exceedsMaximumHeight = this.isMaximumHeightExceeded(); } } @@ -224,6 +220,14 @@ export default class QuanticGeneratedAnswer extends LightningElement { } } + isMaximumHeightExceeded() { + const answerElementHeight = this.isStreaming + ? this.generatedAnswerElementHeight + 50 + : this.generatedAnswerElementHeight; + + return answerElementHeight > this._maximumAnswerHeight; + } + getGeneratedAnswerStatus() { if (!this.state.isVisible) { return this.labels.generatedAnswerIsHidden; @@ -348,6 +352,11 @@ export default class QuanticGeneratedAnswer extends LightningElement { } }; + handleAnswerDoneGenerating = (event) => { + event.stopPropagation(); + this.updateGeneratedAnswerCSSVariables(); + }; + handleToggleCollapseAnswer() { this.state?.expanded ? this.generatedAnswer.collapse() @@ -388,6 +397,7 @@ export default class QuanticGeneratedAnswer extends LightningElement { * Sets the the value of the CSS variable "--maxHeight" the value of the _maximumAnswerHeight property. */ updateGeneratedAnswerCSSVariables() { + this._exceedsMaximumHeight = this.isMaximumHeightExceeded(); if (this._exceedsMaximumHeight) { const styles = this.generatedAnswerElement?.style; styles.setProperty('--maxHeight', `${this._maximumAnswerHeight}px`); diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html index c66a1726caa..207bbca84b9 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html @@ -53,6 +53,7 @@ answer-content-format={answerContentFormat} answer={answer} is-streaming={isStreaming} + onquantic__answergenerated={handleAnswerDoneGenerating} data-cy="generated-answer__content" > diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js index a5e10c46698..fb1b5041331 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js @@ -11,6 +11,7 @@ import generatedTextContentTemplate from './templates/generatedTextContent.html' /** * The `QuanticGeneratedAnswerContent` component displays the generated answer content. * @category Internal + * @fires CustomEvent#quantic__answergenerated * @example * */ @@ -110,6 +111,7 @@ export default class QuanticGeneratedAnswerContent extends LightningElement { else { answerContainer.textContent = this.answer; } + this.dispatchEvent(new CustomEvent('quantic__answergenerated')); } get generatedAnswerContentClass() { From a81d2868e2df52278e724e3f79d4fe0eb24e2459 Mon Sep 17 00:00:00 2001 From: GitHub Actions Bot <> Date: Thu, 16 Jan 2025 16:02:05 +0000 Subject: [PATCH 05/11] Add generated files --- .../atomic-angular/src/lib/stencil-generated/components.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts b/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts index 48ae804850d..293cd556a1c 100644 --- a/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts +++ b/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts @@ -3107,5 +3107,4 @@ export declare interface AtomicTimeframeFacet extends Components.AtomicTimeframe -import type {} from '@coveo/atomic/components'; import type {} from '@coveo/atomic/components'; \ No newline at end of file From 4b3157b82940dc5f1053066c89ede659152193b0 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Thu, 16 Jan 2025 11:06:09 -0500 Subject: [PATCH 06/11] removed css changes --- .../lwc/quanticGeneratedAnswer/templates/generatedAnswer.css | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css index 2b8210c9126..305794d8819 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.css @@ -8,8 +8,6 @@ .generated-answer__answer { overflow: hidden; position: relative; - max-height: var(--maxHeight, 250px); - content: ''; } .generated-answer__footer { From b99f1ac9e1f541d0f9c5683391e16c312fc91b07 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Thu, 16 Jan 2025 11:08:27 -0500 Subject: [PATCH 07/11] cleanup e2e --- .../main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts | 4 ---- .../quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts index e2141571155..24da7fa5eb3 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts @@ -227,10 +227,6 @@ export class GeneratedAnswerObject { return uaRequest; } - async waitForFewSeconds() { - await this.page.waitForTimeout(3000); - } - async waitForGeneratedAnswerCustomUaAnalytics( eventValue: string, customChecker?: Function diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts index 2a57a0e8d5a..674225ed659 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts @@ -175,8 +175,7 @@ useCaseTestCases.forEach((useCase) => { }); }); - test.describe - .only('when the answer is generated in a single shot and the answer exceeds the maximum height', () => { + test.describe('when the answer is generated in a single shot and the answer exceeds the maximum height', () => { test.use({ options: { collapsible: true, From e3561f602fac9f1efeb10a56c452ff0acb8944c8 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Thu, 16 Jan 2025 15:10:10 -0500 Subject: [PATCH 08/11] fix --- .../lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js index 0212bc95f10..3c0daf32e9b 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js @@ -354,6 +354,9 @@ export default class QuanticGeneratedAnswer extends LightningElement { handleAnswerDoneGenerating = (event) => { event.stopPropagation(); + if (this.collapsible) { + this._exceedsMaximumHeight = this.isMaximumHeightExceeded(); + } this.updateGeneratedAnswerCSSVariables(); }; @@ -397,7 +400,6 @@ export default class QuanticGeneratedAnswer extends LightningElement { * Sets the the value of the CSS variable "--maxHeight" the value of the _maximumAnswerHeight property. */ updateGeneratedAnswerCSSVariables() { - this._exceedsMaximumHeight = this.isMaximumHeightExceeded(); if (this._exceedsMaximumHeight) { const styles = this.generatedAnswerElement?.style; styles.setProperty('--maxHeight', `${this._maximumAnswerHeight}px`); From 1ddcd46f9722d3a195be8f50fef148c4155bedf0 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Mon, 20 Jan 2025 09:14:09 -0500 Subject: [PATCH 09/11] applied feedback --- .../lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js | 6 +++--- .../quanticGeneratedAnswer/templates/generatedAnswer.html | 2 +- .../quanticGeneratedAnswerContent.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js index 3c0daf32e9b..0d521e7b86c 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js @@ -151,8 +151,6 @@ export default class QuanticGeneratedAnswer extends LightningElement { renderedCallback() { initializeWithHeadless(this, this.engineId, this.initialize); if (this.collapsible) { - // If we are still streaming add a little extra height to the answer element to account for the next answer chunk. - // This helps a lot with the jankyness of the answer fading out when the chunk is close but not yet over the max height. this._exceedsMaximumHeight = this.isMaximumHeightExceeded(); } } @@ -221,6 +219,8 @@ export default class QuanticGeneratedAnswer extends LightningElement { } isMaximumHeightExceeded() { + // If we are still streaming add a little extra height to the answer element to account for the next answer chunk. + // This helps a lot with the jankyness of the answer fading out when the chunk is close but not yet over the max height. const answerElementHeight = this.isStreaming ? this.generatedAnswerElementHeight + 50 : this.generatedAnswerElementHeight; @@ -352,7 +352,7 @@ export default class QuanticGeneratedAnswer extends LightningElement { } }; - handleAnswerDoneGenerating = (event) => { + handleAnswerContentUpdated = (event) => { event.stopPropagation(); if (this.collapsible) { this._exceedsMaximumHeight = this.isMaximumHeightExceeded(); diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html index 207bbca84b9..8d853aa8ab7 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html @@ -53,7 +53,7 @@ answer-content-format={answerContentFormat} answer={answer} is-streaming={isStreaming} - onquantic__answergenerated={handleAnswerDoneGenerating} + quantic__answercontentupdated={handleAnswerContentUpdated} data-cy="generated-answer__content" > diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js index fb1b5041331..7bd8c7d4451 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js @@ -111,7 +111,7 @@ export default class QuanticGeneratedAnswerContent extends LightningElement { else { answerContainer.textContent = this.answer; } - this.dispatchEvent(new CustomEvent('quantic__answergenerated')); + this.dispatchEvent(new CustomEvent('quantic__answercontentupdated')); } get generatedAnswerContentClass() { From 326ed685c0237ad06f736980bf9d74c6cac74768 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Mon, 20 Jan 2025 09:16:55 -0500 Subject: [PATCH 10/11] updated class description with new event name --- .../quanticGeneratedAnswerContent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js index 7bd8c7d4451..6d8de143c89 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js @@ -11,7 +11,7 @@ import generatedTextContentTemplate from './templates/generatedTextContent.html' /** * The `QuanticGeneratedAnswerContent` component displays the generated answer content. * @category Internal - * @fires CustomEvent#quantic__answergenerated + * @fires CustomEvent#quantic__answercontentupdated * @example * */ From 91ba84a440243c3bb01f45ead91d6eaf1eafd0b7 Mon Sep 17 00:00:00 2001 From: simonmilord Date: Mon, 20 Jan 2025 12:26:39 -0500 Subject: [PATCH 11/11] fix failing test due to typo --- .../lwc/quanticGeneratedAnswer/templates/generatedAnswer.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html index 8d853aa8ab7..5c58de0a0ca 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html @@ -53,7 +53,7 @@ answer-content-format={answerContentFormat} answer={answer} is-streaming={isStreaming} - quantic__answercontentupdated={handleAnswerContentUpdated} + onquantic__answercontentupdated={handleAnswerContentUpdated} data-cy="generated-answer__content" >