Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception message for sdk that doesn't support collectors #459

Closed
MarcoRossignoli opened this issue Jun 9, 2019 · 1 comment · Fixed by #569
Closed

Improve exception message for sdk that doesn't support collectors #459

MarcoRossignoli opened this issue Jun 9, 2019 · 1 comment · Fixed by #569
Labels
enhancement General enhancement request up-for-grabs Good issue for contributors

Comments

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Jun 9, 2019 •
edited
Loading

Moved from #456 (comment)

@vagisha-nidhi's comment

Data collector 'XPlat code coverage' message: System.MissingMethodException: Method not found: '!!0 Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.SessionStartEventArgs.GetPropertyValue(System.String)'.
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetTestModules(SessionStartEventArgs sessionStartEventArgs)
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs).

Should this message be replaced with something more informative (like using the correct sdk version)?

cc: @cltshivash @vagisha-nidhi @tonerdo
@MarcoRossignoli MarcoRossignoli added the enhancement General enhancement request label Jun 9, 2019
@MarcoRossignoli
Copy link
Collaborator Author

Should this message be replaced with something more informative (like using the correct sdk version)?

@vagisha-nidhi yes I agree this error is a bit cryptic. Maybe improve with some advice(catch MissingMethodException and output message like Method not found, make sure to use .NET core SDK version >= 2.2.300 and flow real exc as inner) if we aren't sure that this kind of exception raise only in case of unsupported sdk.

@MarcoRossignoli MarcoRossignoli added the up-for-grabs Good issue for contributors label Jun 10, 2019
@daveMueller daveMueller mentioned this issue Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement General enhancement request up-for-grabs Good issue for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve exception message daveMueller/coverlet
1 participant
@MarcoRossignoli