Coverlet is not considering the excludefromCoverage attribute at method level

[VenkateshSrini]

Hi,
I'm using the Coverlet to measure .NET core 3.1 Web API code coverage. I have used entity framework for creating by repository. There are some methods have anonymous object as return types and hence could not be unit tested. I want those methods to be alone excluded from coverage so I used [ExlcudeFromCodeCoverage] on those methods only. But Coverlet is not considering that at all and still generated the code coverage for the same. Please see the method EditTask in the TaskRepo class as an example in the attached code.
TaskApi.zip

[MarcoRossignoli]

Thank's for repro, I'll take a look asap.

[MarcoRossignoli]

@VenkateshSrini can you tell me where is these methods? I searched [ExlcudeFromCodeCoverage] inside a solution but didn't found anything.

[MarcoRossignoli]

@VenkateshSrini any news?

[VenkateshSrini]

In the repository folder, there is a file called TaskRepo.cs. In that, there is a method called EditTask that has [ExcludeFromCodeCovergae]

[MarcoRossignoli]

I cannot see the attribute what am I missing?

[VenkateshSrini]

No. I just downloaded the attached code bit I'ma able to see the same. Let me upload it once again
TaskApi.zip. please see the code below

Please click on the link on this post to download it

[MarcoRossignoli]

Ok now I can repro, seems a bug, btw you cannot use /p:ExcludeByAttribute="CompilerGenerated" with new version because we fixed a bug and now you lose coverage with every async state machine generated #794 (comment)

Thanks for reporting this.

[VenkateshSrini]

@MarcoRossignoli ,
But that cannot be the way forward that I loose coverage with every async statement. We need to have a standard way out of this problem. What would be your suggestion in such cases?

[MarcoRossignoli]

Why are you using that attribute filter?What do you want to filter out?

[sac80644]

Glad I found this thread. I was just about to report this bug. ExcludeFromCodeCoverage attribute seems to work for non-async methods but not async in my case.

[MarcoRossignoli]

Thanks for the informations

[VenkateshSrini]

@MarcoRossignoli ,
As you can see I want to exclude a few methods fro test coverage as I will not be able to write a proper test for these methods. The reason is they contain a complex inline LINQ query that could not be mocked. Also, those kinds of methods are tested in Functional tests and from coverage statistics. Hence I'm decorating my method with ExcludeFromCodeCovarge on async method.

[MarcoRossignoli]

@VenkateshSrini I understood I meant that you cannot use CompilerGenerated anymore as value for /p:ExcludeByAttribute because it will exclude also all async methods(unrelated to this bug on ExlcudeFromCodeCoverage), I saw it in your command line.

[VenkateshSrini]

ok. So how should I go about this in the current scenario

[MarcoRossignoli]

I'm fixing, for the moment you could use partials and put method you don't want cover into it and filter out with exclude by filename https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/MSBuildIntegration.md#source-files.
Let me know if you want a PoC

[MarcoRossignoli]

Should be fixed, feel free to reopen if needed.

[romainf-ubi]

Is it possible that [ExcludeFromCodeCoverage] only works with coverlet.msbuild package and not coverlet.collector?

[MarcoRossignoli]

Is it possible that [ExcludeFromCodeCoverage] only works with coverlet.msbuild package and not coverlet.collector?

Engine is the same so I expect same behavior