fix #248, support gaps in labeled interval interpolation #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: coverage percentage decrease here is because the rewrite of |
craffel
requested changes
Apr 15, 2017
documentation update
Added gap test to interpolate_intervals
bmcfee
force-pushed
the
ival-to-sample-gaps
branch
from
9f0cba1 to
e695ece
Compare
Done. |
|
Thanks! |
craffel
pushed a commit
that referenced
this pull request
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites
util.interpolate_intervalsto support gaps in the intervals properly.For now, I added documentation to indicate that
time_pointsshould be in ascending order. We can either tighten this by adding a validation check, or loosen it and extend the function to support unordered time grids.