[4.x]: Deactivate by default user setting not working

[yzaman24]

What happened?

Description

The deactivate by default setting for public user registrations does not work and is not used.

Specifically this part of the Users Controller's action "SaveUser" :
// If this is a new user and email verification isn't required, // go ahead and activate them now. if ($isNewUser && !$requireEmailVerification) { Craft::$app->getUsers()->activateUser($user); }

There is a var ($deactivateByDefault) that is not used in the logic above.

Steps to reproduce

1. Select the checkbox labelled "Deactivate users by default" under user settings.
2. Create a registration form on the front-end that will create a user outside of the control panel.
3. User gets added already activated.

Expected behavior

With the option above enabled, users should not be activated upon registration.

Actual behavior

Users are activated after creation.

Craft CMS version

4.0.5

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[brandonkelly]

That setting only comes into effect during public registration. If you were logged-in with your existing account when you submitted the registration form, then that’s just normal user registration (identical to creating a user from the control panel).

[yzaman24]

I understand that, but I don't think it works. I am carrying out a public registration. Each time, the account is activated by default and I am able to log in as that user.

[Mosnar]

I was able to reproduce this issue when the "Verify email addresses" setting is unchecked.

[brandonkelly]

Thanks! Just got this fixed for the next release.

[brandonkelly]

Craft 4.1.1 is out now with that fix.