[3.x]: index-assets/one with specific folder and --delete-missing-assets=1 is very dangerous combination

[timbertens]

What happened?

Description

This combination just lost a large chunk of the asset index entries on a large number of sites

Steps to reproduce

1. Have a S3 volume 'shared' somewhere with different subfolder1, subfolder2, subfolder3, etc
2. Run 'php craft index-assets/one shared/subfolder2 --delete-missing-assets=1

Expected behavior

The subfolder2 gets indexed and if there are missing assets in subfolder2 then they are removed from the index

Actual behavior

The subfolder2 gets indexed, all files that are not re-indexed (so those from subfolder1, subfolder2 and subfolder3) are removed from the index

Is an issue in 3.x for sure, might also be in future versions ...

Craft CMS version

3.9.6

PHP version

7.4.30

Operating system and version

not relevant

Database type and version

not relevant

Image driver and version

not relevant

Installed plugins and versions

not relevant

[i-just]

Hi, thanks for reporting! I raised PRs to adjust this.

[brandonkelly]

Craft 3.9.10, 4.5.14, and 5.0.0-alpha.4 are out with a fix for this. Thanks again.