[4.x]: wrong type annotation in generated CustomFieldBehavior

[d--j]

What happened?

Description

cms/src/behaviors/CustomFieldBehavior.php.template

Lines 31 to 34 in c51f730

	/**
	* @var string[] List of supported field handles.
	*/
	public static $fieldHandles = [

the type annotation string[] is wrong here. What gets generated is a bool[] or more specifically an array<string,bool>:

    public static $fieldHandles = [
        'field1' => true,
        'field2' => true,
        'field3' => true,
    ];

PHPStan (level 5) trips over this.

A stub file like this

<?php

namespace craft\behaviors;

class CustomFieldBehavior
{
    /**
     * @var array<string,bool>
     */
    public static $fieldHandles = [];
}

fixes this but you might just want to use the correct type annotation in the first place so this stub is not necessary anymore.

Craft CMS version

4.7.3

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[brandonkelly]

Thanks for pointing that out! Fixed for the next release.

[brandonkelly]

Craft 4.7.4 is out with that fix. Note you’ll need to run php craft clear-caches/compiled-classes to regenerate CustomFieldBehavior.