Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Config always creates site with default name and handle #3661

Closed
boboldehampsink opened this issue Jan 18, 2019 · 2 comments
Closed

Comments

@boboldehampsink
Copy link
Contributor

boboldehampsink commented Jan 18, 2019

Description

Project Config always creates a site with default name and handle. When renaming the default site's name and handle it saves to project.yaml, but when installing a new site with this file it still uses the default name and default handle, and saves that back to project.yaml

screen shot 2019-01-18 at 08 34 10

Steps to reproduce

  1. Set up Craft and rename default site and its handle
  2. Install new Craft with that project.yaml
  3. See project.yaml changed to default site and handle again

Additional info

  • Craft version: 3.1.1
  • PHP version: 7.3.1
  • Database driver & version: PostgreSQL 10.6
  • Plugins & versions: N/A
@brandonkelly
Copy link
Member

Yeah this is a little awkward because the installer lets you choose the site name, so we should be respecting that over whatever is in project.yaml I think. That said I suppose we can update the installer to set the default site name value to the value in project.yaml if that’s present. And we can leave the handle alone – that was never user-submitted anyway.

In Base URL’s case that might be a step in the wrong direction though, as the default value is based on the current request’s URL, which is more likely to be correct than whatever is in project.yaml.

@brandonkelly
Copy link
Member

3.1.2 is out with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants