Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero margin at the bottom of Assets creation screen in CP #4644

Closed
vaughn-taylor opened this issue Jul 23, 2019 · 2 comments
Closed

Zero margin at the bottom of Assets creation screen in CP #4644

vaughn-taylor opened this issue Jul 23, 2019 · 2 comments

Comments

@vaughn-taylor
Copy link

Description

This is not preventing functionality, it's just a styling issue I noticed after I upgraded to Craft 3.2. There's no margin at the bottom of the Assets creation screen at /admin/settings/assets/volumes/new

Steps to reproduce

Additional info

  • Craft version: 3.2.6
  • PHP version:
  • Database driver & version:
  • Plugins & versions:
@brandonkelly
Copy link
Member

brandonkelly commented Jul 23, 2019 •
edited
Loading

Thanks, looks like that was introduced by #3905 which fixed a similar bug (#3874), but only for the Settings → Plugins page, and only for Firefox. So for now I’ve just reverted that change, and will look into a better fix for Firefox that doesn’t break other pages’ bottom paddings.

@vaughn-taylor
Copy link
Author

vaughn-taylor commented Jul 23, 2019 via email •
edited
Loading

This was referenced Sep 12, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @vaughn-taylor