Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindex assets missing assets model closes undexpectedly #4795

Closed
nickcobley opened this issue Aug 22, 2019 · 1 comment
Closed

Reindex assets missing assets model closes undexpectedly #4795

nickcobley opened this issue Aug 22, 2019 · 1 comment

Comments

@nickcobley
Copy link

Description

Bit of a long-standing issue that I run into every now and again, but it's quite frustrating when I do.

If you reindex the assets, at the end of the process if there are any missing this modal is displayed:

Screenshot 2019-08-22 13 31 39

The problem is if you click outside the window, it closes the modal without any confirmation rather than requiring you to select either "Cancel" or "OK".

Where this causes usability issues, in particular, is long-running operations. Few times I've been reindexing a large remote source like S3 which may take 15 minutes or more to run. When it finishes, instinct is to click on the inactive browser window, when you do, that first click to activate the window/tab if outside that modal window closes the window with the list of missing assets.

When this happens you then have to run the reindex again to get the list of missing assets.

Steps to reproduce

  1. Reindex an asset source that has missing images
  2. When the missing image modal shows, click outside the window

Additional info

  • Craft version: 3.2.10
  • Browser: Chrome 76.0.3809.100
@brandonkelly
Copy link
Member

Good point! Just fixed this for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants