Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query for drafts also returns drafts of soft deleted entries #4797

Closed
ghost opened this issue Aug 22, 2019 · 1 comment
Closed

Query for drafts also returns drafts of soft deleted entries #4797

ghost opened this issue Aug 22, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 22, 2019

Description

When an entry with existing drafts is soft deleted, those drafts are still returned by queries.

Should be soft deleted as a whole with all its drafts. (Didn't check that for revisions...)

PS.
It's also possible to open an edit screen for this draft, entering the url manually.

Thanks.

Steps to reproduce

  1. Create a draft for an existing entry
  2. Soft delete the entry
  3. Run craft.entries.drafts(true).all
  4. The draft for this entry will be returned.

Additional info

  • Craft version: 3.2.10
  • PHP version:
  • Database driver & version:
  • Plugins & versions:
@brandonkelly
Copy link
Member

Thanks for pointing that out! Just fixed this for the next release.

To get the fix early, change your craftcms/cms requirement in composer.json to:

"require": {
  "craftcms/cms": "dev-develop#283bdaca9925be2f22e413ef1f586a90038a9618 as 3.2.10",
  "...": "..."
}

Then run composer update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant