-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer warning that content will be deleted when a user account is deleted #875
Comments
Same thing here, the client accidentally deleted half their site after an employee quit. :) |
I had the same thing. Deleted half the site. Luckly we had a back up but many don't. |
Client just nuked the majority of their site content because of this... they simply didn't realise that was going to happen... |
We've had this happen too. People don't read, and for action as bad as this they need to. Elsewhere destructive actions require the user to put their password in again - this should be the same. |
Ok, we have had two clients do this now. Destructive actions should require the user to put their password in again. |
I just had a client do this (thankfully, the damage was minimal). Requiring a password entry with a clear prompt is a great idea. |
We have had this happen again recently, and the client deleted the previous "master user". They nuked 80% of the site, and didn't tell us for a couple of weeks. No backups available. This is really dangerous default behaviour. |
Someone pointed out on Craft Slack:
|
@MattWilcox Backups definitely should be part of any site, imo: https://nystudio107.com/blog/mitigating-disaster-via-website-backups That said, I'd tend to agree that it should at least be made harder for this to happen. I see two ways to do that:
The former gives people an idea of the implications of their action, which they may not have otherwise. It's reasonable that some people would think that deleting a user would delete just that user. Even though the dialog indicates that "all the content created by that user" will be deleted, actually showing the things that will be nuked I think will make a better connection with people. The latter forces people to slow down, and hopefully read the former. And the implication of having to re-auth forces them to consider that the action they are about to take is important. |
Just caught that this had moved to here - good. Upgraded from #craft3: From 'some' experience anyway, would suggest there's no effective way to enlighten clients on the fly about this kind of thing - they will just look away and keep pressing that button or enter key. How does it sound to just disable (or copy to another stack) any user being 'deleted'. Then provide a way for a superadministrator to curry - or reinstate -- later? |
@narration-sd something like that would probably be done more at the element level: #867 |
@takobell Indeed, that would be great. Upvoting... And maybe the framework for another request, duplicating content. (I know, head in hands on that one, but understandably desired...) |
The problem is the person clicks "Delete" and what looks to them like an "Are you sure you want to delete?" dialog pops up, so without thinking they click on "Delete it" (confirming yes, I really want to delete it), and then click Delete. Hiding it in a dropdown slows them down. Better UX might be a dropdown menu that defaults to "Transfer it to" so they can't even see "Delete it" without slowing down and reading what's on the screen. Which is actually the problem. And maybe a warning symbol with warning text if they select "Delete it" |
Even if they do choose to delete, that should trigger exactly the same protection as when editing a user account - force them to put their password in. It makes them slow down and actually pay attention. I'd also suggest doing an automatic database backup on such massively destructive actions as this. |
While we do want to improve the modal (mainly to spell out exactly what will be deleted by the action), we’re also thinking we should implement #867, so even if the content is chosen to be deleted, both the user and their entries will really just be archived, and only give admins the ability to actually hard-delete anything. |
Just make the ability to actually delete things a permission? Admin only won't work for all situations, but the idea is right. Only privileged users should be blessed with such destructive powers. |
You also end up with a front-end problem; if the user thinks they've deleted/archived another user, should pages that the archived user created be displayed on the front end? That's what the people making these mistakes believe should happen because they're not reading that deleting a user also deletes the content they made... but if we instead archive things then those pages that the user made won't show because that's not what happens when we archive pages. |
Not a bad idea. Can you post as a new FR though?
No, but the point of the archive is, when it happens, it is easily fixable (just un-archive the entries). |
Wow, we just deleted our website as a result of this preposterous default behavior. We will now be looking at alternatives. |
When a user account is deleted, all content input by that user is also deleted. There is a modal that pops up asking what you want to do with their content (ie you can transfer it to another user), but the warning needs to be bigger and scarier! One client didn't read the message properly thinking it was just a 'delete user' confirmation pop up. A simple update but it might prevent some major stress.
The text was updated successfully, but these errors were encountered: