Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to apply Free (0 costs) shipping to the cart #387

Closed
krizajb opened this issue Jun 21, 2018 · 4 comments
Closed

Unable to apply Free (0 costs) shipping to the cart #387

krizajb opened this issue Jun 21, 2018 · 4 comments

Comments

@krizajb
Copy link

krizajb commented Jun 21, 2018

Description

If shipping doesn't cost anything (0) the cart doesn't get updated. The controller returns (test ajax) cart without shipping method being updated. If shipping method isn't free, the method successfully applies to the cart.

Checking at the controller source, the cart shippingMethodHandle is set but get's reverted during saveElement call.

Using default shop templates and latest commerce (2.0.0-beta.5) reproduces the mentioned behavior.

Steps to reproduce

  1. Add shipping method without costing anything or use the default commerce 2 shipping method.
  2. Attempt to apply free shipping method to the cart.
  3. Shipping method not applied to the cart.

Additional info

  • Craft version: Craft Pro 3.0.11
  • PHP version: 7.1.7
  • Database driver & version: MySQL 5.6.34
  • Plugins & versions:
    • Craft Commerce 2.0.0-beta.5
    • Mollie for Craft Commerce 1.0.0
@lukeholder
Copy link
Member

lukeholder commented Jun 22, 2018

I just pulled in this fix: #388

Does that pull request fix your issue? Monkey patch the file to test. Thanks.

@krizajb
Copy link
Author

krizajb commented Jun 22, 2018

Unfortunately that doesn't solve this issue.

@lukeholder
Copy link
Member

Thanks for reporting will be fixed in the next release. Switch to dev-develop in your composer for commerce if you need the changes sooner. Thanks.

@krizajb
Copy link
Author

krizajb commented Jun 26, 2018

Will do, thank you! Can confirm the fix solves the issue. When are you planning to make a new version update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants