Saving product with variants with custom fields and auto SKU fails and clears custom fields

[tomdeleu]

Description

I have a product type setup with variants with custom fields on the variant, and with an automatic SKU format
(in my case: "{product.slug|upper}-{title|kebab|upper}")

When trying to save such a new product with more than 1 variant, saving fails due to input validation, and custom fields are cleared. SKU's are shown, and you can Immediately save again. But of course, you lose your initial custom field values. (You can fill them in again, and they are saved the second attempt.)

I made a short video to show: https://cl.ly/3P3i2z0e3A0M

Note:
When trying to save with 1 variant included, everything works. More than one fails...

Steps to reproduce

1. Product with variants and custom fields on the variant, and automatic SKU format
2. Add product, fill out everything and save
3. You'll see the input validation being shown for nothing. Custom fields are cleared.

Additional info

• Craft version: Craft Solo 3.0.20
• PHP version: 7.1.20
• Database driver & version: MySQL 5.7.23

[lukeholder]

Thanks, this has been fixed. Issue was caused by validation error on the uniqueness of the SKU when they have not been generated yet. Your version of Commerce in the video did not show the validation error, but we now generate the SKUs before validating the product.