Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Handling Of Duplicate Discount Codes #569

Closed
tobyjug opened this issue Nov 15, 2018 · 1 comment
Closed

Better Handling Of Duplicate Discount Codes #569

tobyjug opened this issue Nov 15, 2018 · 1 comment
Labels
bug

Comments

@tobyjug
Copy link

tobyjug commented Nov 15, 2018

Description

When adding a coupon code under discounts, if that coupon code already exists then Craft produces an Internal Server Error rather than an expected flash error/warning.

Steps to reproduce

  1. Add new discount with coupon code and save
  2. Add discount with same coupon code and save

Additional info

  • Craft version: 3.0.30.2
  • PHP version: 7.2.10
  • Database driver & version: MySQL 5.7.23
  • Plugins & versions: Commerce 2.0.0-beta.13.1
@lukeholder lukeholder added the bug label Nov 26, 2018
@lukeholder
Copy link
Member

Thanks, fixed for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukeholder @tobyjug