Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set defaults in v3.3.3 #453

Closed
MalikDrako opened this issue Jan 4, 2019 · 4 comments
Closed

Unable to set defaults in v3.3.3 #453

MalikDrako opened this issue Jan 4, 2019 · 4 comments

Comments

@MalikDrako
Copy link

jquery-confirm version:
v3.3.3

I'm submitting a ... (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request

Current behavior:
When I try to set defaults after updating to v3.3.3 as shown here, I get an error:

Uncaught ReferenceError: jconfirm is not defined

My code is not run until after the plugin is loaded, and it worked in v3.3.2

Other information:

I am using the plugin in a browser-like environment (Phonegap) and include it with:

<script type="text/javascript" src="js/plugins/jquery-confirm.min.js"></script>
@CornelZ
Copy link

CornelZ commented Jan 8, 2019

I got the same problem.
I looked in the .js file and it seemed that the vars jconfirm and Jconfirm are not global anymore as they were in version 3.3.2.

I moved the declaration of the vars outside the function and it worked.
Sry for not making a pull request on this.

@craftpip
Copy link
Owner

craftpip commented Jan 8, 2019

Will make a fix for this today itself, sorry

@craftpip
Copy link
Owner

Fixed in release v3.3.4, please reopen if any queries

@DanieleGBX
Copy link

@craftpip could you publish 3.3.4 on npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants