Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly has different motion behaviour (jumps are higher) #905

Closed
letmaik opened this issue May 17, 2015 · 4 comments
Closed

Nightly has different motion behaviour (jumps are higher) #905

letmaik opened this issue May 17, 2015 · 4 comments

Comments

@letmaik
Copy link

letmaik commented May 17, 2015

I believe this is connected to @mucaho's improved motion system. Basically, using identical gravity etc. values for twoway, I get different jumping heights. Is that supposed to be? If so, it has to be mentioned in some migration/release notes later on.

You can very easily verify this behaviour by cloning https://github.com/neothemachine/hungrymonkey and then in index.html commenting out one or the other crafty include (0.6.3 vs nightly) and then see how high the monkey is jumping (e.g. use your finger to capture the highest height...).

@mucaho
Copy link
Contributor

mucaho commented May 17, 2015

@letmaik
Copy link
Author

letmaik commented May 17, 2015 via email

@mucaho
Copy link
Contributor

mucaho commented May 17, 2015

Hmm, even so, these formulas shouldn't produce that different results. I guess the biggest culprit is that jumping behaves differently now - it adds upwards velocity now, whereas before it manipulated the y directly. Incorrect, net effect of old and new jump behavior should be same.
Yeah, there are couple of backward-incompatible changes we must not forget to address in change log.

@mucaho
Copy link
Contributor

mucaho commented Nov 6, 2015

added to 0.7 release notes

@mucaho mucaho closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants